2.x: fix timeout with fallback not cancelling the main source #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.57% (diff: 100%)@@ 2.x #4945 diff @@
==========================================
Files 587 587
Lines 37549 37551 +2
Methods 0 0
Messages 0 0
Branches 5655 5655
==========================================
- Hits 35904 35891 -13
- Misses 692 702 +10
- Partials 953 958 +5
|
JakeWharton
approved these changes
Dec 29, 2016
This was referenced Dec 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the lack of dispose/cancel call towards the upstream in the timed+fallback
timeoutoperator version.In addition, the selector version received similar unit tests to ensure they work properly (they did).
Related: #4944.